Add NetworkBoundaryBuilder argument to inject_network_boundaries#463
Open
gabotechs wants to merge 1 commit into
Open
Add NetworkBoundaryBuilder argument to inject_network_boundaries#463gabotechs wants to merge 1 commit into
gabotechs wants to merge 1 commit into
Conversation
This was referenced May 23, 2026
gabotechs
changed the base branch from
main
to
gabrielmusat/report-tasks-in-benchmarks
gabotechs
force-pushed
the
gabrielmusat/report-tasks-in-benchmarks
branch
from
f9f778f to
5711027
Compare
gabotechs
force-pushed
the
gabrielmusat/network-boundary-builder
branch
from
382dc95 to
110bbce
Compare
gabotechs
force-pushed
the
gabrielmusat/report-tasks-in-benchmarks
branch
from
5711027 to
3d31017
Compare
gabotechs
force-pushed
the
gabrielmusat/network-boundary-builder
branch
from
110bbce to
567c155
Compare
gabotechs
added a commit
that referenced
this pull request
May 26, 2026
… be the same (#427) This is one PR from the following stack of PRs: - #427 <- you are here - #469 - #461 - #462 - #463 - #464 - #432 This is a preparatory step towards: - #377 This is an optimization that allows workers to communicate in-memory avoiding network calls and serialization in case it needs to communicate to itself. This optimization shows good improvements if using a small number of workers, and fades away as more workers are used. Even if this shows improvements today, it will become very meaningful in adaptative query execution: there will be times when two consecutive stages are assigned 1 task each, and as that was done dynamically, we cannot eagerly do the optimization that collapses those two stages into one, so instead, we assigned both stages to the same worker, and the optimization in this PR kicks in, executing the plan fully locally.
gabotechs
force-pushed
the
gabrielmusat/report-tasks-in-benchmarks
branch
from
3d31017 to
68c26dc
Compare
gabotechs
force-pushed
the
gabrielmusat/network-boundary-builder
branch
from
567c155 to
d1c7428
Compare
gabotechs
added a commit
that referenced
this pull request
May 27, 2026
This is one PR from the following stack of PRs: - #427 - #469 <- you are here - #461 - #462 - #463 - #464 - #432 This PR factors out common recursion patterns used in the distributed planner into reusable helpers, reducing complexity in critical parts of the codebase. By centralizing recursion logic, we improve code maintainability and reduce the risk of subtle bugs in recursive tree traversals.
gabotechs
force-pushed
the
gabrielmusat/report-tasks-in-benchmarks
branch
from
68c26dc to
14e2ff4
Compare
gabotechs
force-pushed
the
gabrielmusat/network-boundary-builder
branch
from
d1c7428 to
4093882
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one PR from the following stack of PRs:
This PR introduces a NetworkBoundaryBuilder argument to the network boundary injection logic, allowing more flexible and configurable strategies for determining which exchanges require network communication. This enables better optimization of data movement across distributed tasks.