feat: add --schema-name option to test command#1085
Open
kelsoufi-sanofi wants to merge 4 commits intodatacontract:mainfrom
Open
feat: add --schema-name option to test command#1085kelsoufi-sanofi wants to merge 4 commits intodatacontract:mainfrom
kelsoufi-sanofi wants to merge 4 commits intodatacontract:mainfrom
Conversation
Add --schema-name flag to `datacontract test` to filter which schema object to test, consistent with the existing --schema-name on `export`. Defaults to "all" (existing behavior). When a specific schema name is provided, only checks for that schema are generated and executed. Closes datacontract#1079 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jochenchrist
requested changes
Mar 21, 2026
Author
|
@jochenchrist should be good now. let me know. thanks |
jschoedl
requested changes
Apr 8, 2026
| # TODO check server is supported type for nicer error messages | ||
| # TODO check server credentials are complete for nicer error messages | ||
| if server.format == "json" and server.type != "kafka": | ||
| check_jsonschema(run, data_contract, server) |
Collaborator
There was a problem hiding this comment.
But this will still run for all schemas, or did I overlook something?
|
|
||
| def test_test_schema_name_option_in_help(): | ||
| """Test that --schema-name option is available in test command help.""" | ||
| result = runner.invoke(app, ["test", "--help"]) |
Collaborator
There was a problem hiding this comment.
Suggested change
| result = runner.invoke(app, ["test", "--help"]) | |
| result = runner.invoke(app, ["test", "--help"], env={"COLUMNS": "200"}) |
Seems like the test output gets truncated in the CI test, making --schema-name not fully appear there. Increasing the terminal width for this specific test could help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1079
Summary
--schema-nameoption to thetestcommand, allowing users to test a specific schema (e.g.,--schema-name orders) instead of all schemas"all", preserving existing behaviorTest plan
pytest)--schema-nameoptionruff formatandruff checkpass clean