issue264 fixed

[jeestr4d]

issue #264 fixed.

local pytest results:

jeestrad@JEESTRAD-M-L6VV ACI-Pre-Upgrade-Validation-Script % python3 -m pytest tests/auto_firmware_update_ondiscovery_check
======================================================================== test session starts =========================================================================
platform darwin -- Python 3.9.6, pytest-8.2.0, pluggy-1.5.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
plugins: anyio-4.8.0
collected 9 items

tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs0-None-None-MANUAL CHECK REQUIRED]
--------------------------------------------------------------------------- live log setup ---------------------------------------------------------------------------
[11:01:52.381 INFO initialize:5347] Cleaning up previous run files in preupgrade_validator_logs/
[11:01:52.382 INFO initialize:5349] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
PASSED [ 11%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs1-5.2(7a)-None-MANUAL CHECK REQUIRED] PASSED [ 22%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs2-None-6.0(3d)-MANUAL CHECK REQUIRED] PASSED [ 33%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs3-5.2(7a)-6.0(2d)-N/A] PASSED [ 44%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs4-6.0(3a)-6.0(9d)-N/A] PASSED [ 55%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs5-5.2(7a)-6.0(3d)-FAIL - OUTAGE WARNING!!] PASSED [ 66%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs6-6.0(2a)-6.0(3d)-FAIL - OUTAGE WARNING!!] PASSED [ 77%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs7-5.2(7a)-6.0(3d)-PASS] PASSED [ 88%]
tests/auto_firmware_update_ondiscovery_check/test_auto_firmware_update_ondiscovery_check.py::test_logic[icurl_outputs8-5.2(7a)-6.0(3d)-PASS] PASSED [100%]

========================================================================= 9 passed in 0.06s ==========================================================================

result from lab:

[Check 87/87] Auto Firmware Update on Switch Discovery... FAIL - OUTAGE WARNING!!
Auto firmware Policy Dn Switch enforced Version

---

uni/fabric/fwrepop n9000-16.0(8f)

Recommended Action: Disable the Auto Firmware Update on Switch Discovery policy before upgrade
Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#auto-firmware-update-on-switch-discovery

[takishida]

• Rebased it to the latest master to resolve conflicts
• Updated the version check because it was incorrectly flagging versions like 5.3.2 -> 6.0.9.
• Updated the query from class to DN because there is only one object instance for Auto Firmware Update and DN query is less expensive.
• Updated the doc to correctly describe the issue and why we do this check as part of pre-upgrade validation.
• Changed the failure type to MANUAL from FAIL_O because this issue does NOT cause outage just because a regular upgrade was performed. See the updated doc for details.

Example output:

admin@apic1:techsupport> python aci-preupgrade-validation-script.py --api-only -d auto_firmware_update_on_switch_check -c "6.0(1a)" -t "6.2(1g)"

--- skip ---

=== Check Result (failed only) ===

[Check 1/1] Auto Firmware Update on Switch Discovery...                                                              MANUAL CHECK REQUIRED
  Auto Firmware Update Status  Default Firmware Version  Upgrade Target Version
  ---------------------------  ------------------------  ----------------------
  Enabled                      n9000-16.1(5e)            6.2(1g)

  Recommended Action: Disable Auto Firmware Update before the upgrade as a precaution. See the reference doc for details.
  Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#auto-firmware-update-on-switch-discovery