fix: allow reserved keywords for field names in the Rust SDK#257
Merged
flaviofcruz merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
flaviofcruz
force-pushed
the
flavio-cruz_data/allow-some-reserved-keywords-sdk-schema
branch
from
f7bf4ff to
1b1a9b2
Compare
teodordelibasic-db
approved these changes
Apr 29, 2026
elenagaljak-db
approved these changes
Apr 29, 2026
flaviofcruz
deleted the
flavio-cruz_data/allow-some-reserved-keywords-sdk-schema
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
I confirmed with protoc that both proto3 and proto2 are ok with using these keywords as field names so we don't need to be so restrictive.
How is this tested?
Existing unit tests and added a new one.