Skip to content

Auth validation update#1700

Open
simonfaltum wants to merge 3 commits into
mainfrom
simonfaltum/callback-result-issuer
Open

Auth validation update#1700
simonfaltum wants to merge 3 commits into
mainfrom
simonfaltum/callback-result-issuer

Conversation

@simonfaltum
Copy link
Copy Markdown
Member

Update to auth validation logic

NO_CHANGELOG=true

Carry the OAuth callback's iss parameter on the same oauthResult that
carries the code and state, so all three originate from the same callback
request. Removes the parallel lastIssuer field and its mutex.

Co-authored-by: Isaac
Signed-off-by: Simon Faltum <simon.faltum@databricks.com>
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 27, 2026 11:38 — with GitHub Actions Inactive
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 27, 2026 11:40 — with GitHub Actions Inactive
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 27, 2026 11:40 — with GitHub Actions Inactive
@simonfaltum simonfaltum marked this pull request as ready for review May 27, 2026 15:25
@simonfaltum simonfaltum requested a review from pietern May 27, 2026 15:25
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 27, 2026 15:39 — with GitHub Actions Inactive
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 27, 2026 15:39 — with GitHub Actions Inactive
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 27, 2026 15:41 — with GitHub Actions Inactive
@simonfaltum simonfaltum marked this pull request as draft May 27, 2026 15:56
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 27, 2026 15:58 — with GitHub Actions Inactive
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 27, 2026 15:58 — with GitHub Actions Inactive
@simonfaltum simonfaltum marked this pull request as ready for review May 27, 2026 15:59
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 27, 2026 16:00 — with GitHub Actions Inactive
@simonfaltum simonfaltum temporarily deployed to test-trigger-is May 28, 2026 10:34 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1700
  • Commit SHA: e6a0e93cb907b3c2e94a3353342439dfce07901b

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant