Mark auto-generated files for GitHub linguist#5269
Conversation
Extends linguist-generated coverage beyond the genkit CLI stubs in cmd/account and cmd/workspace to include direct engine YAML, schema artifacts, mocks, pydabs codegen, acceptance test golden outputs, and the genkit-managed tagging workflow. Entries land in .gitattributes.manual so they survive `./task generate-genkit`, which overwrites .gitattributes and then prepends the manual file. Co-authored-by: Isaac
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
|
||
| # Acceptance test golden outputs (./task test-update, ./task test-update-templates) | ||
| acceptance/**/out* linguist-generated=true | ||
| acceptance/**/output/** linguist-generated=true |
There was a problem hiding this comment.
I like seeing these on all PRs because it forces you to acknowledge any side effects of the change.
Sometimes the unexpected behavior is captured only inside the output files.
| python/databricks/bundles/volumes/** linguist-generated=true | ||
|
|
||
| # Acceptance test golden outputs (./task test-update, ./task test-update-templates) | ||
| acceptance/**/out* linguist-generated=true |
There was a problem hiding this comment.
I think all the output of the acceptance test is important to see explicitly as it helps to detect the changes in behaviour
| internal/mocks/**/*.go linguist-generated=true | ||
|
|
||
| # Genkit-generated tagging artifacts (./task generate-genkit) | ||
| internal/genkit/tagging.py linguist-generated=true |
There was a problem hiding this comment.
I'd maybe keep this unhidden because if there's something changes here it can affect the release process
3 participants
Changes
Extends
linguist-generated=truecoverage in.gitattributes(and its.gitattributes.manualsource) so generated files don't pollute language stats or show up as hand-written code in reviews. Added patterns:./task generate-directbundle/direct/dresources/*.generated.yml./task generate-schema-docsbundle/schema/jsonschema_for_docs.json./task generate-schemabundle/internal/schema/annotations_openapi.yml./task generate-docsbundle/docsgen/output/*.mdmockeryinternal/mocks/**/*.go./task generate-genkitinternal/genkit/tagging.py{,.lock},.github/workflows/tagging.yml./task pydabs-codegenpython/databricks/bundles/{catalogs,jobs,pipelines,schemas,volumes}/**./task test-update{,-templates}acceptance/**/out*,acceptance/**/output/**Entries go into
.gitattributes.manual(prepended onto genkit's output by./task generate-genkit, perTaskfile.yml:768) and are mirrored into the live.gitattributesso they take effect immediately.Why
bundle/direct/dresources/apitypes.generated.yml(andresources.generated.yml) were showing up as human-authored code on GitHub. The genkit-managed section of.gitattributesonly coverscmd/account/**andcmd/workspace/**, so the rest of the auto-generated tree was unmarked. This brings linguist's view in line with.agent/rules/auto-generated-files.md.Tests
Verified each pattern with
git check-attr linguist-generated <path>:true.bundle/direct/dresources/apitypes.yml,bundle/internal/schema/annotations_openapi_overrides.yml,bundle/internal/schema/annotations.yml,internal/mocks/README.md,python/databricks/bundles/core/**,python/databricks/bundles/build.py,acceptance/test.toml,acceptance/**/script,acceptance/**/databricks.yml) stayunspecified..gitattributes(TF schema, validation generated, root jsonschema, acceptance out.test.toml) still resolve correctly../task wspasses.This PR was written by Claude Code.