fix: handle array-returning Vite plugins in mergeConfigDedup#89
Merged
pffigueiredo merged 5 commits intomainfrom Feb 26, 2026
Merged
fix: handle array-returning Vite plugins in mergeConfigDedup#89pffigueiredo merged 5 commits intomainfrom
pffigueiredo merged 5 commits intomainfrom
Conversation
Flatten nested arrays and filter falsy values before deduplicating, matching Vite's own PluginOption handling. Fixes crash with plugins like @tailwindcss/vite that return Plugin[]. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Pedro Figueiredo <klisarkk@gmail.com>
Member
|
@MarioCadenas please take a look, as I'm not sure if this doesn't conflict with your changes in the plugins area? |
pkosiec
approved these changes
Feb 26, 2026
Member
pkosiec
left a comment
There was a problem hiding this comment.
LGTM - but please resolve the comment before the merge. Thank you!
| .turbo | ||
|
|
||
| # AI generated plans from developer loop | ||
| docs/plans No newline at end of file |
Member
There was a problem hiding this comment.
let's remove this - it might be confusing as our docs directory contain actually docs. AFAIK the path is configurable for claude code, so IMO it's better to use ./tmp maybe?
MarioCadenas
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mergeConfigDedupassumed every entry in thepluginsarray is a singlePluginobject with a.nameproperty. However, Vite'sPluginOptiontype allows plugins to be arrays (nested), falsy values, or promises. Plugins like@tailwindcss/vitereturnPlugin[]— a standard Vite convention called "plugin presets." This causedmergeConfigDedupto fail because it accessed.nameon an array.FIXES
@tailwindcss/viteand similar)false,null,undefined) — standard Vite convention for conditional plugins.nameworks correctly for all plugin typesTest Plan
Added unit tests in
packages/appkit/src/utils/tests/vite-config-merge.test.tscovering:Manual Testing
appkitto make sure this fixed the issue