Fix: surface mid-stream OAuth errors as login chip#216
Open
annzhang-db wants to merge 1 commit into
Open
Conversation
…dering
Raw error chunks ({ type: 'error', errorText }) were forwarded as-is to the
client, which only renders data-error parts. This meant OAuth credential errors
never surfaced as the login chip — they were logged but silently dropped by
the client's message rendering pipeline.
Co-authored-by: Ann Zhang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ type: 'error', errorText }chunksdata-errorparts, so these errors were logged but never displayed{ type: 'data-error', data: errorText }soisCredentialErrorMessagecan match them andMessageOAuthErrorrenders the login chipRoot cause
stream-fallback.tshad one code path that correctly emitteddata-error(infallbackToGenerateText) but the mid-stream error forwarding path wrote the raw AI SDK error chunk instead. The client ignorestype: 'error'chunks entirely.Test plan
MessageErrorcomponentThis pull request and its description were written by Claude.