[PLUGIN-1952] Add column details in logging in case of invalid data#147
Open
Ashutosh-Jarvis wants to merge 3 commits intodata-integrations:developfrom
Open
[PLUGIN-1952] Add column details in logging in case of invalid data#147Ashutosh-Jarvis wants to merge 3 commits intodata-integrations:developfrom
Ashutosh-Jarvis wants to merge 3 commits intodata-integrations:developfrom
Conversation
Ashutosh-Jarvis
changed the title
|
|
||
| @Test | ||
| public void testConvertToDoubleValue() throws ParseException { | ||
| Assert.assertEquals(42.0, ServiceNowRecordConverter.convertToDoubleValue("42"), 0.0); |
Contributor
There was a problem hiding this comment.
write a test case to compare error message
vikasrathee-cs
approved these changes
Mar 30, 2026
itsankit-google
requested changes
Mar 30, 2026
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
-
Please add a JIRA to the PR.
-
Also add proper description:
- It should be able to answer What, Why and Testing details.
vikasrathee-cs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLUGIN-1952 Add column details in logging in case of invalid data
In case of invalid data mention the column name along with wrong data.