fix: update membership on login instead of rejecting (singleMembership)#115
Open
aymericcousaert wants to merge 3 commits intomasterfrom
Open
fix: update membership on login instead of rejecting (singleMembership)#115aymericcousaert wants to merge 3 commits intomasterfrom
aymericcousaert wants to merge 3 commits intomasterfrom
Conversation
…rship is enabled When singleMembership is true and a user already belongs to the org with a different department, update the existing membership instead of throwing "cet utilisateur est déjà membre de cette organisation". This fixes SAML SSO login failures when the IdP assigns a different department than what the user currently has.
The pre-push hook runs `npm run quality` which includes tests. Tests require Node 24 for native .ts support, but husky hooks don't inherit the fnm shell environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
singleMembershipis enabled and a user already belongs to an org with a different department,addMembernow updates the existing membership (department, role) instead of throwing"cet utilisateur est déjà membre de cette organisation"Test plan