fix: decode hex-escaped non-ASCII chars in LDAP bind DN#114
Merged
Conversation
ldapjs v3's DN.toString() hex-escapes non-ASCII UTF-8 characters (e.g., é → \c3\a9) per RFC 4514. However, ber.writeString() in the bind request sends these as literal text, not actual UTF-8 bytes. This causes DN mismatches on Active Directory for users with accented characters in their CN (e.g., Dié, Marie-Noelle).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DN.toString()hex-escapes non-ASCII UTF-8 characters (e.g.,é→\c3\a9) per RFC 4514, butber.writeString()in the bind request sends these as literal text instead of actual UTF-8 bytesInvalidCredentialsErroron Active Directory for users with accented characters in their CN (e.g.,Dié, Marie-Noelle)unescapeNonAsciiInDn()utility that decodes hex sequences back to UTF-8 and re-escapes only DN-special charsFiles changed
api/src/utils/dn.ts— new utility function (15 lines)api/src/storages/ldap.ts— import + one-line fix incheckPasswordtest-it/unescape-dn.ts— 4 unit tests + 1 integration test with bind spy (proves the DN encoding issue and that the fix resolves it)Test plan
\c3\a9→éand DN-special chars are re-escapedclient.bind()and asserts the DN contains rawé, not hex-escaped\c3\a9