refactor(key-wallet): drop dashcore::FeeRate

[ZocoLini]

We already have the FeeRate struct in KeyWallet, there is no point in maintaining twice the same struct

Summary by CodeRabbit

Release Notes

• Breaking Changes
  • The FeeRate type and its associated public API have been removed, including all constants, constructors, and conversion methods. Code depending on FeeRate will require updates.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fa3224 and d3d8c03.

📒 Files selected for processing (3)

• dash/src/blockdata/fee_rate.rs
• dash/src/blockdata/mod.rs
• dash/src/lib.rs

💤 Files with no reviewable changes (3)

• dash/src/blockdata/mod.rs
• dash/src/lib.rs
• dash/src/blockdata/fee_rate.rs

---

📝 Walkthrough

Walkthrough

The PR removes the entire FeeRate type from the public API by deleting the fee_rate module file and all associated re-exports from the blockdata and library root modules, resulting in a breaking change to the codebase's public interface.

Changes

Cohort / File(s)	Summary
FeeRate Module Removal dash/src/blockdata/fee_rate.rs	Deleted entire module containing FeeRate struct, constants (ZERO, MIN, MAX, BROADCAST_MIN, DUST), constructors, accessors, arithmetic operations (checked_mul, checked_div), trait implementations (Display, From, Mul, Div), and parsing support (202 lines removed).
Public API Re-export Cleanup dash/src/blockdata/mod.rs, dash/src/lib.rs	Removed module declaration and public re-exports of FeeRate from blockdata and library root, eliminating the type from the public API surface.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Farewell, dear FeeRate, you've hopped away,
No more sat-per-kwu calculations here to stay,
The module's cleared, the types are gone,
A lighter codebase hops along! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor(key-wallet): drop dashcore::FeeRate' directly and clearly describes the main change: removing the FeeRate struct from dashcore. It aligns with the PR objective of eliminating the duplicate FeeRate implementation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/drop-dashcore-feerate

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}