WIP: feat: add pubkeyToPkh and addrToPkh to keyUtils#77
Open
WIP: feat: add pubkeyToPkh and addrToPkh to keyUtils#77
pubkeyToPkh and addrToPkh to keyUtils#77Conversation
pubkeyToPkh and addrToPkh to keyUtilspubkeyToPkh and addrToPkh to keyUtils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We have a few conflicting concerns:
getaddressutxosis unreliablegetaddressdeltasandgetaddressmempoolare missingscriptdashpay/dash#6215getaddressdeltasandgetaddressmempoolare reliable, but are missingscriptgetaddressdeltasandgetaddressmempoolare missingscriptdashpay/dash#6215To solve this we can do any of:
keyUtils(proposed)The Cumbersome Code
In particular, going from the tx draft to the tx final + signed requires a bit more ceremony than I'd like: