Allow to use the package with scheb/2fa bundle#54
Open
jbtronics wants to merge 1 commit intodarookee:masterfrom
Open
Allow to use the package with scheb/2fa bundle#54jbtronics wants to merge 1 commit intodarookee:masterfrom
jbtronics wants to merge 1 commit intodarookee:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes makes the package compatible with scheb/2fa-bundle.
The problem is that this breaks compatibility with the old scheb/two-factor-bundle (as to my knowledge composer does not offer support to require either one or another package). So the changes should be released as a new major version.