fix(kasm): add db initialization check before migrations (upstream PR #30)#58
Open
fix(kasm): add db initialization check before migrations (upstream PR #30)#58
Conversation
Port of kasmtech/kasm-helm#30 (matonb). Adds a pre-check in the db-init-job that queries SELECT COUNT(*) FROM settings before running startup.sh. If the database is already initialized, the job exits immediately instead of running redundant Alembic migrations. This prevents unnecessary lock acquisition during migrations when the schema is already current, reducing the risk of the deadlock loop documented in kasmtech/kasm-helm#36. Upstream-PR: kasmtech/kasm-helm#30 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SELECT COUNT(*) FROM settingsbefore running Alembic migrationsWhy
We hit repeated deadlocks where the db-init-job ran Alembic migrations unnecessarily, acquiring
AccessExclusiveLocks that blocked all other KASM components. This guard prevents that when the schema is already current. Related: kasmtech/kasm-helm#36.Test plan
helm lint charts/kasmhelm template— verify the init script includes the settings table check🤖 Generated with Claude Code