feat(kasm): separate db-init-job annotations (upstream PR #29)#57
Open
feat(kasm): separate db-init-job annotations (upstream PR #29)#57
Conversation
Port of kasmtech/kasm-helm#29 (matonb). Creates dedicated components.init_db.annotations and components.init_db.labels configuration separate from components.api. The db-init-job template uses this dedicated variable instead of sharing API annotations. Default value includes helm.sh/hook: pre-install for Helm deployments, but GitOps/ArgoCD users can override this to remove the hook and prevent deployment deadlocks. Upstream-PR: kasmtech/kasm-helm#29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components.init_db.annotationsandcomponents.init_db.labelsconfiginit_dbinstead ofapivariableshelm.sh/hook: pre-install; GitOps users can override to prevent deadlocksWhy
Enables adding
pre-upgradeandhook-delete-policyvia values overrides instead of template forks. Complements our issue kasmtech/kasm-helm#35 findings 3 and 4.Test plan
helm lint charts/kasmhelm templatewith default values — verify db-init-job hashelm.sh/hook: pre-installhelm templatewith customcomponents.init_db.annotations— verify override works🤖 Generated with Claude Code