feat: add application-level keepalive to prevent ALB idle connection timeouts#1695
Open
JoshVanL wants to merge 2 commits intodapr:masterfrom
Open
feat: add application-level keepalive to prevent ALB idle connection timeouts#1695JoshVanL wants to merge 2 commits intodapr:masterfrom
JoshVanL wants to merge 2 commits intodapr:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an application-level gRPC keepalive loop in the Durable Task worker to reduce the chance of idle HTTP/2 connections being closed (e.g., by AWS ALBs) while the worker is waiting on the long-lived getWorkItems stream.
Changes:
- Introduces a scheduled keepalive task that periodically calls a unary RPC (
hello) on the sidecar. - Starts the keepalive loop after opening the work-item stream and stops it on disconnect/retry and on
close(). - Adds supporting constants/imports and scheduler lifecycle management.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
durabletask-client/src/main/java/io/dapr/durabletask/DurableTaskGrpcWorker.java
Outdated
Show resolved
Hide resolved
durabletask-client/src/main/java/io/dapr/durabletask/DurableTaskGrpcWorker.java
Outdated
Show resolved
Hide resolved
durabletask-client/src/main/java/io/dapr/durabletask/DurableTaskGrpcWorker.java
Outdated
Show resolved
Hide resolved
durabletask-client/src/main/java/io/dapr/durabletask/DurableTaskGrpcWorker.java
Outdated
Show resolved
Hide resolved
…timeouts AWS ALBs do not forward HTTP/2 PING frames, causing idle gRPC connections to be closed. This adds a background loop that periodically calls the existing Hello RPC as application-level traffic to keep the connection alive through L7 load balancers. Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
grpc-keepalive-hello
branch
from
2bbf43a to
bfdb4a4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1695 +/- ##
============================================
- Coverage 79.53% 79.51% -0.02%
- Complexity 2193 2194 +1
============================================
Files 237 237
Lines 6577 6577
Branches 730 730
============================================
- Hits 5231 5230 -1
- Misses 990 992 +2
+ Partials 356 355 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS ALBs do not forward HTTP/2 PING frames, causing idle gRPC connections to be closed. This adds a background loop that periodically calls the existing Hello RPC as application-level traffic to keep the connection alive through L7 load balancers.