Skip to content

Adds request fifoMessageGroupId for SNS/SQS#4175

Closed
joshm998 wants to merge 1 commit intodapr:mainfrom
joshm998:main
Closed

Adds request fifoMessageGroupId for SNS/SQS#4175
joshm998 wants to merge 1 commit intodapr:mainfrom
joshm998:main

Conversation

@joshm998
Copy link
Copy Markdown

@joshm998 joshm998 commented Jan 15, 2026

Description

Adds support for the fifoMessageGroupId field in request metadata for the SNS/SQS pubsub component.

Order of precedence:

  1. Request Metadata
  2. Component Metadata
  3. Generated

Issue reference

#3415

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@joshm998 joshm998 requested review from a team as code owners January 15, 2026 07:41
@joshm998 joshm998 changed the title Adds request fifoMessageGroupId for SNS/SQS (#3415) Adds request fifoMessageGroupId for SNS/SQS Jan 15, 2026
Copy link
Copy Markdown
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joshm998 thx for the PR here 🎉

Can you add a test to pubsub/aws/snssqs/snssqs_test.go and fix the linter issue?

@cicoyle cicoyle added this to the v1.17 milestone Jan 16, 2026
@joshm998
Copy link
Copy Markdown
Author

Hey @cicoyle no problem, added tests for testing the message group id precedence and fixed the linting issue.

@joshm998 joshm998 requested a review from cicoyle January 21, 2026 10:03
Signed-off-by: Josh Mangiola <contact@joshmangiola.com>
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Feb 20, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot closed this Feb 27, 2026
@joshm998
Copy link
Copy Markdown
Author

joshm998 commented Mar 1, 2026

Hi this is ready for review as the issues have been addressed

@yaron2 yaron2 reopened this Mar 1, 2026
@github-actions github-actions Bot removed the stale label Mar 1, 2026
@dapr-bot
Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Apr 10, 2026
@dapr-bot
Copy link
Copy Markdown
Collaborator

This pull request has been automatically closed because it was marked stale with no further activity for 7 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants