Skip to content

common: fix "The pool was not closed" message (no ADR failure) #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janekmi wants to merge 1 commit into
base: stable-2.1
Choose a base branch
from
+9 −3
Open

common: fix "The pool was not closed" message (no ADR failure) #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
XXX

* Version X.X.X

- Fix "The pool was not closed" message (no ADR failure) (daos-stack/pmdk#1, DAOS-18692)

Fri Jan 16 2026 Oksana Sałyk <oksana.salyk@hpe.com>

* Version 2.1.3
Expand Down
2 changes: 1 addition & 1 deletion src/common/shutdown_state.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ shutdown_state_check(struct shutdown_state *curr_sds,
* but there wasn't an ADR failure
*/
CORE_LOG_WARNING(
"The ADR failure was detected but the pool was closed properly - reinitializing ADR failure detection.");
"The pool was not closed - reinitializing ADR failure detection.");
shutdown_state_reinit(curr_sds, pool_sds, rep);
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/util_sds/grep5.log.match
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<libpmem2>: <2> [shutdown_state.c:$(N) shutdown_state_check] The ADR failure was detected but the pool was closed properly - reinitializing ADR failure detection.
<libpmem2>: <2> [shutdown_state.c:$(N) shutdown_state_check] The pool was not closed - reinitializing ADR failure detection.
2 changes: 1 addition & 1 deletion src/test/util_sds_check/out2.log.match
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ util_sds_check$(nW)TEST2: START: util_sds_check
src version: $(nW)
compiled with support for shutdown state
compiled with libndctl $(nW)
The ADR failure was detected but the pool was closed properly - reinitializing ADR failure detection.
The pool was not closed - reinitializing ADR failure detection.
util_sds_check$(nW)TEST2: DONE
Loading