Skip to content

SRE-3534 ci: fix Commit Pragma tests#497

Open
grom72 wants to merge 11 commits intomasterfrom
grom72/SRE-3534-fix-tests
Open

SRE-3534 ci: fix Commit Pragma tests#497
grom72 wants to merge 11 commits intomasterfrom
grom72/SRE-3534-fix-tests

Conversation

@grom72
Copy link
Contributor

@grom72 grom72 commented Mar 13, 2026

SRE-3534 ci: fix Commit Pragma tests to follow latest changes in isPr() introduced by #495

grom72 added 8 commits March 13, 2026 11:50
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
This reverts commit 7665d46.
Skip-daos-build-and-test: true
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72 grom72 requested a review from phender March 13, 2026 13:02
@grom72 grom72 changed the title Grom72/sre 3534 fix tests SRE-3534 ci: fix Commit Pragma tests Mar 13, 2026
@grom72
Copy link
Contributor Author

grom72 commented Mar 13, 2026

The 'DAOS Build and Test' stage has been cancelled because the changes do not affect the main 'pipeline-lib' functionality.

https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/pipeline-lib/job/PR-497/6/pipeline-overview

@grom72 grom72 requested a review from osalyk March 13, 2026 13:12
osalyk
osalyk previously approved these changes Mar 13, 2026
@grom72 grom72 requested a review from a team March 13, 2026 13:46
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
grom72 added 2 commits March 16, 2026 11:21
This reverts commit c605ad6.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72 grom72 requested review from osalyk and phender March 16, 2026 12:58
Comment on lines +538 to +542
if (expect != actual) {
unstable ('FAIL: ' + ' expect: ' + expect + ' actual: ' + actual + ' for stage ' + stage)
} else {
println ('PASS: ' + ' expect: ' + expect + ' actual: ' + actual + ' for stage ' + stage)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be personal preference, but I find:

[2026-03-12T17:39:34.902Z]   Result  Expect  Actual  Stage
[2026-03-12T17:39:34.934Z]   ------  ------  ------  ------------------------------------------
[2026-03-12T17:39:34.994Z]   PASS    skip    skip    Functional on Leap 15
[2026-03-12T17:39:35.017Z]   PASS    skip    skip    Functional on CentOS 7
[2026-03-12T17:39:35.037Z]   PASS    skip    skip    Functional on EL 8
[2026-03-12T17:39:35.081Z]   PASS    skip    skip    Functional on EL 9
[2026-03-12T17:39:35.102Z]   PASS    skip    skip    Functional Hardware Medium
[2026-03-12T17:39:35.126Z]   PASS    skip    skip    Functional Hardware Medium Verbs Provider
[2026-03-12T17:39:35.149Z]   PASS    skip    skip    Functional Hardware Medium UCX Provider
[2026-03-12T17:39:35.172Z]   PASS    skip    skip    Functional Hardware Large

a little easier to read than:

[2026-03-16T12:58:44.219Z] PASS:  expect: skip actual: skip for stage Functional on Leap 15
[2026-03-16T12:58:44.344Z] PASS:  expect: skip actual: skip for stage Functional on CentOS 7
[2026-03-16T12:58:44.376Z] PASS:  expect: skip actual: skip for stage Functional on EL 8
[2026-03-16T12:58:44.401Z] PASS:  expect: skip actual: skip for stage Functional on EL 9
[2026-03-16T12:58:44.447Z] PASS:  expect: skip actual: skip for stage Functional Hardware Medium
[2026-03-16T12:58:44.487Z] PASS:  expect: skip actual: skip for stage Functional Hardware Medium Verbs Provider
[2026-03-16T12:58:44.537Z] PASS:  expect: skip actual: skip for stage Functional Hardware Medium UCX Provider
[2026-03-16T12:58:44.578Z] PASS:  expect: skip actual: skip for stage Functional Hardware Large

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point, but my intention is to see results directly from pipeline-overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants