Open
Conversation
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
This reverts commit 7665d46. Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Contributor
Author
|
The 'DAOS Build and Test' stage has been cancelled because the changes do not affect the main 'pipeline-lib' functionality. |
osalyk
previously approved these changes
Mar 13, 2026
phender
requested changes
Mar 13, 2026
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
This reverts commit c605ad6. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
phender
approved these changes
Mar 16, 2026
Comment on lines
+538
to
+542
| if (expect != actual) { | ||
| unstable ('FAIL: ' + ' expect: ' + expect + ' actual: ' + actual + ' for stage ' + stage) | ||
| } else { | ||
| println ('PASS: ' + ' expect: ' + expect + ' actual: ' + actual + ' for stage ' + stage) | ||
| } |
Contributor
There was a problem hiding this comment.
This could be personal preference, but I find:
[2026-03-12T17:39:34.902Z] Result Expect Actual Stage
[2026-03-12T17:39:34.934Z] ------ ------ ------ ------------------------------------------
[2026-03-12T17:39:34.994Z] PASS skip skip Functional on Leap 15
[2026-03-12T17:39:35.017Z] PASS skip skip Functional on CentOS 7
[2026-03-12T17:39:35.037Z] PASS skip skip Functional on EL 8
[2026-03-12T17:39:35.081Z] PASS skip skip Functional on EL 9
[2026-03-12T17:39:35.102Z] PASS skip skip Functional Hardware Medium
[2026-03-12T17:39:35.126Z] PASS skip skip Functional Hardware Medium Verbs Provider
[2026-03-12T17:39:35.149Z] PASS skip skip Functional Hardware Medium UCX Provider
[2026-03-12T17:39:35.172Z] PASS skip skip Functional Hardware Large
a little easier to read than:
[2026-03-16T12:58:44.219Z] PASS: expect: skip actual: skip for stage Functional on Leap 15
[2026-03-16T12:58:44.344Z] PASS: expect: skip actual: skip for stage Functional on CentOS 7
[2026-03-16T12:58:44.376Z] PASS: expect: skip actual: skip for stage Functional on EL 8
[2026-03-16T12:58:44.401Z] PASS: expect: skip actual: skip for stage Functional on EL 9
[2026-03-16T12:58:44.447Z] PASS: expect: skip actual: skip for stage Functional Hardware Medium
[2026-03-16T12:58:44.487Z] PASS: expect: skip actual: skip for stage Functional Hardware Medium Verbs Provider
[2026-03-16T12:58:44.537Z] PASS: expect: skip actual: skip for stage Functional Hardware Medium UCX Provider
[2026-03-16T12:58:44.578Z] PASS: expect: skip actual: skip for stage Functional Hardware Large
Contributor
Author
There was a problem hiding this comment.
I see your point, but my intention is to see results directly from pipeline-overview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRE-3534 ci: fix Commit Pragma tests to follow latest changes in
isPr()introduced by #495