Refresh homepage Recent Work and Professional sections#38
Refresh homepage Recent Work and Professional sections#38
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d054bdfd56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const resetPointerPosition = () => { | ||
| const scene = sceneRef.current; | ||
|
|
||
| if (!scene) { | ||
| return; | ||
| } | ||
|
|
||
| scene.style.setProperty("--pointer-ratio-x", "0"); | ||
| scene.style.setProperty("--pointer-ratio-y", "0"); |
There was a problem hiding this comment.
Cancel pending animation frame on pointer leave
If the pointer leaves the scene before the queued requestAnimationFrame callback runs, resetPointerPosition sets both CSS vars to 0 and then the pending callback immediately writes stale non-zero values back. In that sequence, the panel can remain tilted even when the pointer is no longer over it, until another pointer event happens. Canceling rafRef.current in resetPointerPosition (before resetting vars) avoids this visual state bug.
Useful? React with 👍 / 👎.
| The homepage now pulls directly from the same portfolio dataset, | ||
| so project imagery stays in sync with the full Selected Work page. | ||
| </p> | ||
| <div className="portfolio-carousel-controls" aria-hidden="true"> |
There was a problem hiding this comment.
Remove aria-hidden from interactive carousel controls
aria-hidden="true" on the controls container removes its subtree from the accessibility tree while it still contains clickable <button> elements. Screen-reader users won’t be able to discover/use these desktop carousel controls, and focusable elements inside an aria-hidden subtree are an accessibility violation. The container should not be aria-hidden if the buttons are intended to be interactive.
Useful? React with 👍 / 👎.
Summary
What changed
Recent Work image sourcing
How the Professional animation works
Tradeoffs and follow-ups