Sync Recent Work to portfolio images and elevate Professional section motion#36
Sync Recent Work to portfolio images and elevate Professional section motion#36
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8d3a074b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| height={300} | ||
| sizes="(max-width: 767px) 200px, (max-width: 1199px) 200px, 300px" | ||
| /> | ||
| <div className="portfolio-controls" aria-hidden="true"> |
There was a problem hiding this comment.
Remove aria-hidden from interactive carousel controls
Applying aria-hidden="true" to the container that holds the prev/next <button> elements hides those controls from assistive technologies while they remain focusable and clickable, which creates an accessibility regression for screen-reader users on desktop. In practice, users relying on AT cannot discover or reliably operate carousel navigation even though the buttons are present visually.
Useful? React with 👍 / 👎.
Motivation
Description
homepageRecentWorkItems(derived fromportfolioItems) inapp/util/const.ts, removing inline hardcoded image imports and establishing a single source of truth.app/components/home/portfolio.tsx, including smooth scroll, scroll-snap, and intentional image sizing.app/components/home/professional.tsxto a layered UI composition (staggered panels, subtle glows/grid, intersection-triggered reveal, pointer-based parallax) withprefers-reduced-motionsupport and a simplified mobile layout.app/styles.css(scene, panels, glows, carousel controls) and kept the implementation dependency-free and lightweight for performance.Testing
npm run lintand it completed (one ESLint warning for an<img>elsewhere, not introduced by these changes).npm run buildand a production build completed successfully with pages generated and no build errors.Codex Task