Skip to content

allow value field name in combination with builder#131

Merged
danlehmann merged 2 commits intomainfrom
allow-value-field-names-with-builder-2
Mar 27, 2026
Merged

allow value field name in combination with builder#131
danlehmann merged 2 commits intomainfrom
allow-value-field-names-with-builder-2

Conversation

@robamu
Copy link
Copy Markdown
Collaborator

@robamu robamu commented Mar 13, 2026

Fixes #126

@robamu robamu mentioned this pull request Mar 13, 2026
@robamu robamu requested review from danlehmann and estebank March 13, 2026 09:15
@danlehmann
Copy link
Copy Markdown
Owner

Thanks for the fix! Quick question: What if we made it a tuple struct instead? That .0 wouldn't clash with anything ever. Happy to merge as-is though.

Regardless, would you mind adding a note to the changelog?

@robamu
Copy link
Copy Markdown
Collaborator Author

robamu commented Mar 14, 2026

What if we made it a tuple struct instead? That .0 wouldn't clash with anything ever.

Good idea. no renaming needed then. Might try this.

@robamu
Copy link
Copy Markdown
Collaborator Author

robamu commented Mar 21, 2026

Okay, I pushed the change to use a unit tuple structure. however, I still need to mangle the value input argument o prevent nameclashes with a value generic..

@robamu robamu force-pushed the allow-value-field-names-with-builder-2 branch from ec33327 to fd99bd0 Compare March 21, 2026 19:39
@robamu robamu requested a review from danlehmann March 21, 2026 19:39
@danlehmann danlehmann merged commit ad90f84 into main Mar 27, 2026
14 checks passed
@danlehmann danlehmann deleted the allow-value-field-names-with-builder-2 branch March 27, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field name value in combination with the builder API is problematic with v2

2 participants