Added support for executing a sub-workflow#1363
Open
kfrajtak wants to merge 7 commits intodanielgerlag:masterfrom
Open
Added support for executing a sub-workflow#1363kfrajtak wants to merge 7 commits intodanielgerlag:masterfrom
kfrajtak wants to merge 7 commits intodanielgerlag:masterfrom
Conversation
danielgerlag
requested changes
Sep 20, 2025
Owner
danielgerlag
left a comment
danielgerlag
left a comment
There was a problem hiding this comment.
Happy to merge this if we can revert the WaitFor primitive changes.
| } | ||
|
|
||
| return ExecutionResult.WaitForEvent(EventName, EventKey, effectiveDate); | ||
| var eventKey = context.Workflow.Reference ?? EventKey; |
Owner
There was a problem hiding this comment.
This does not make sense, why would we default to the reference field as the wait key? This could be a major breaking change.
Owner
There was a problem hiding this comment.
I don't think we should be changing the behaviour of the WaitFor primitive to support this feature
…an approved event, the key is the id from the input - i.e. the thing user has under control
kfrajtak
force-pushed
the
subworkflow
branch
from
66d3b90 to
d966515
Compare
Author
|
@danielgerlag I have undone the changes made to core. Can you review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
This PR adds a support to run a sub-workflow from the main workflow.
Describe your implementation or design
New step builder was added to support sub-workflow. The step starts a new workflow when executed with given workflow id (name). The workflow gets an reference to main workflow, the main workflow then waits for a workflow completed event triggered from the sub-workflow and continues.
If sub-event expects an event then the event should be published with parent workflow id since the sub-workflow id is not known.
An error in the sub-workflow terminates it and consequently terminates the parent workflow as well.
Tests
Yes
Breaking change
EndWorflowwill raise theWorkflowCompletedevent (which will probably solve If using EndWorkflow() no event for WorkflowCompleted LifeCycleEvent #1353)ExecutionErrortable