Round the value to prevent a Firefox error#4
Open
cpowell wants to merge 1 commit intodanguer:masterfrom
cpowell:master
Open
Round the value to prevent a Firefox error#4cpowell wants to merge 1 commit intodanguer:masterfrom cpowell:master
cpowell wants to merge 1 commit intodanguer:masterfrom
cpowell:master
Conversation
…fox. (Chrome appears to work it out on its own just fine.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'bytes' value for my data was ending up as a decimal, e.g. 415.5. I found that Firefox was erroring on this value; Chrome seemed to handle it in stride. By applying Math.round() to the bytes variable, Firefox got a lot happier.