Skip to content

Fixing bug in locate_conditions#1

Open
webdestroya wants to merge 1 commit into
dangerp:masterfrom
webdestroya:master
Open

Fixing bug in locate_conditions#1
webdestroya wants to merge 1 commit into
dangerp:masterfrom
webdestroya:master

Conversation

@webdestroya
Copy link
Copy Markdown

Current gem is incorrectly accessing the :locate_conditions function, and so it is never being called.

@dangerp
Copy link
Copy Markdown
Owner

dangerp commented Apr 9, 2013

The OmniAuth::Strategy::Options attributes can be accessed as methods or using hash notation. The style I used is inconsistent with the rest of the class, but it is still correct. Do you have a breaking test case that demonstrates the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants