Open
Conversation
…harge power calculations
Contributor
Author
|
I have move it to bmw i3 protocol. |
Owner
There was a problem hiding this comment.
Can you revert all changes to Software.cpp?
…and discharge power calculations" This reverts commit bbe8c9a.
Contributor
Author
|
I have revert change back to software.cpp |
Owner
|
Yes can you add a configurable option? Or do you need help with it? |
Contributor
Author
|
I have changed it so that it can be turned on and off in inverter config on the setting page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR implements a low pass filter on charge rate that is sent to inverter, to prevent oscillation when battery is charging
Why
Why does it do it?
How
Low pass filter only allow increasing values (10% new, 90% old)