Safety: Add user set voltage charge/discharge stop#2137
Merged
dalathegreat merged 3 commits intomainfrom Apr 17, 2026
Merged
Conversation
Owner
Author
|
Tested OK on Discord, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds user set voltage charge/discharge stop to safety handler
Why
It has been theorized this might help on protocols such as BYD for Deye to ensure charging actually stops when the float voltage is reached. Good overall safety improvement.
How
If we go over/under the user set limits (+2.0V hysteresis), the allowed charge/discharge values are written to 0W
Tip
You can help test this PR with this guide