Skip to content

[DABOM-495] lib-kafka v1.0.1로 변경#59

Merged
ChoiSeungeon merged 3 commits intodevelopfrom
refactor/DABOM-495
Mar 18, 2026
Merged

[DABOM-495] lib-kafka v1.0.1로 변경#59
ChoiSeungeon merged 3 commits intodevelopfrom
refactor/DABOM-495

Conversation

@ChoiSeungeon
Copy link
Contributor

🍀 이슈 & 티켓 넘버


🎯 목적

lib-kafka v1.0.1에 새로 추가된 notificationType에 맞추기 위함

📝 변경 사항

lib-kafka v1.0.0에서 lib-kafka v1.0.1으로 버전업

📂 변경 범위

도메인 controller service repository entity infra global
usage [x]

🖥️ 주요 코드 설명

private NotificationPayload buildBlockedAlert(
            String eventId,
            LocalDateTime eventDateTime,
            UsagePayload usagePayload,
            String notificationStatus) {
        Map<String, Object> data =
                createBaseData(eventId, eventDateTime, usagePayload, notificationStatus);
        data.put("reason", notificationStatus);

        String message =
                switch (notificationStatus) {
                    case "MANUAL" -> "현재 데이터 사용이 관리자 설정으로 차단되었습니다.";
                    case "APP_BLOCK" -> buildAppBlockMessage(usagePayload.appId());
                    case "TIME_BLOCK" -> "현재 시간에는 데이터 사용이 제한됩니다.";
                    case "MONTHLY_LIMIT_EXCEEDED" -> "개인 월 사용량 한도를 초과했습니다.";
                    case "FAMILY_QUOTA_EXCEEDED" -> "가족 데이터 사용량을 모두 소진했습니다.";
                    default -> "현재 데이터 사용이 차단되었습니다.";
                };

        return new NotificationPayload(
                usagePayload.familyId(),
                usagePayload.customerId(),
                NotificationType.CUSTOMER_BLOCKED,
                "데이터 사용 차단",
                message,
                data);
    }

NotificationType 변경

💬 리뷰어에게


📋 체크리스트

기본

  • Merge 대상 브랜치가 올바른가?
  • ./gradlew build가 정상적으로 통과하는가?
  • Spotless / Checkstyle을 통과하는가? (./gradlew spotlessApply checkstyleMain)
  • 전체 변경사항이 500줄을 넘지 않는가?

코드 품질

  • 의존성 방향을 준수하는가? (Controller → Service → Repository → Entity)
  • Setter 없이 비즈니스 메서드로 상태를 변경하는가?
  • @Transactional은 Service에만 선언했는가?

테스트

  • 신규 비즈니스 로직에 대한 단위 테스트를 작성했는가?

📌 참고 사항

@github-actions github-actions bot added the size/XS PR size: XS label Mar 18, 2026
@github-actions github-actions bot requested a review from swthewhite March 18, 2026 07:18
@github-actions github-actions bot added chore 기타 변경사항 refactor 리팩토링 labels Mar 18, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 lib-kafka 라이브러리를 v1.0.1로 업데이트하여, 라이브러리에 새로 추가된 notificationType에 맞추기 위한 변경 사항을 포함합니다. 이를 통해 시스템이 최신 라이브러리 기능을 활용하고, 알림 처리 로직의 일관성을 유지할 수 있도록 합니다.

Highlights

  • lib-kafka 라이브러리 버전 업데이트: lib-kafka 라이브러리를 v1.0.0에서 v1.0.1로 업데이트했습니다.
  • NotificationType 변경: lib-kafka v1.0.1에 맞춰 NotificationType.BLOCKED를 NotificationType.CUSTOMER_BLOCKED로 변경했습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 lib-kafka 라이브러리를 v1.0.1로 업데이트하고, 이에 맞춰 NotificationTypeBLOCKED에서 CUSTOMER_BLOCKED로 변경하는 내용을 담고 있습니다. 변경 사항은 PR의 목적에 부합하며 올바르게 적용되었습니다. 코드 변경 사항을 검토했으며, 특별한 문제는 발견되지 않았습니다.

@github-actions
Copy link

SonarQube Quality Summary (Community)

Quality Gate PASSED

Branch: refactor/DABOM-495
Compared to: default branch

Issues

  • 🐞 Bugs: 7
  • 🔐 Vulnerabilities: 0
  • 📎 Code Smells: 93

Measures

  • Coverage: 0%
  • Duplication: 0%

🔗 Dashboard: https://sonarqube.swthewhite.store/dashboard?id=dabom-processor-usage&branch=refactor/DABOM-495

Generated automatically by GitHub Actions.

Copy link
Member

@k0081915 k0081915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@github-actions github-actions bot added size/M PR size: M and removed size/XS PR size: XS labels Mar 18, 2026
@github-actions
Copy link

SonarQube Quality Summary (Community)

Quality Gate PASSED

Branch: refactor/DABOM-495
Compared to: default branch

Issues

  • 🐞 Bugs: 7
  • 🔐 Vulnerabilities: 0
  • 📎 Code Smells: 93

Measures

  • Coverage: 0%
  • Duplication: 0%

🔗 Dashboard: https://sonarqube.swthewhite.store/dashboard?id=dabom-processor-usage&branch=refactor/DABOM-495

Generated automatically by GitHub Actions.

Copy link
Member

@k0081915 k0081915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@ChoiSeungeon ChoiSeungeon merged commit 5e822fc into develop Mar 18, 2026
9 checks passed
@ChoiSeungeon ChoiSeungeon deleted the refactor/DABOM-495 branch March 18, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore 기타 변경사항 refactor 리팩토링 size/M PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DABOM-495] lib-kafka 버전 동기화 및 타입 이름 변경

2 participants