Skip to content

Fill in AIC/BIC section with detailed content and attributions#394

Merged
d-morrison merged 8 commits intomainfrom
copilot/fill-in-aic-bic-details
Apr 10, 2026
Merged

Fill in AIC/BIC section with detailed content and attributions#394
d-morrison merged 8 commits intomainfrom
copilot/fill-in-aic-bic-details

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

  • Expand the AIC/BIC section in Linear-models-overview.qmd with:
    • Contextual introduction (visible, not just notes) about when to use AIC/BIC vs LRT
    • Formulas in :::{#def-aic} and :::{#def-bic} definition divs
    • Conceptual explanation of what the penalty terms mean (fit term vs. penalty term)
    • Comparison of AIC vs BIC in a table (penalty per parameter, tendency to select)
    • Detailed interpretation guidelines
    • Attribution to @vittinghoff2e and @kleinbaum2014applied
    • Speaker notes citing Akaike (1974) and Schwarz (1978) for historical context
  • Add Akaike (1974) and Schwarz (1978) to references.bib
  • Add "Kullback" and "Leibler" to inst/WORDLIST
  • Lint check passed (no issues in code I wrote)
  • Resolve merge conflicts with origin/main (AIC/BIC content moved to _sec_linreg_gof.qmd subfile)

Copilot AI linked an issue Apr 9, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits April 9, 2026 20:04
Copilot AI changed the title [WIP] Add details for AIC/BIC section Fill in AIC/BIC section with detailed content and attributions Apr 9, 2026
Copilot AI requested a review from d-morrison April 9, 2026 20:06
Comment thread Linear-models-overview.qmd Outdated
Agent-Logs-Url: https://github.com/d-morrison/rme/sessions/264ec644-046b-4544-872b-1334b56bd97f

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Copilot AI requested a review from d-morrison April 10, 2026 09:11
@d-morrison
Copy link
Copy Markdown
Owner

@copilot resolve merge conflicts

…file

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 10, 2026

@copilot resolve merge conflicts

Done in 75d0c75. Merged origin/main (which had moved the Goodness of fit section to _sec_linreg_gof.qmd) and incorporated the AIC/BIC improvements into that subfile.

@github-actions
Copy link
Copy Markdown
Contributor

PR Preview Action v1.8.1
🚀 Preview available at: https://d-morrison.github.io/rme/pr-preview/pr-394/

Built to branch gh-pages at 2026-04-10 20:45 UTC.

@d-morrison d-morrison marked this pull request as ready for review April 10, 2026 21:03
Copilot AI review requested due to automatic review settings April 10, 2026 21:03
@d-morrison d-morrison merged commit b676cf0 into main Apr 10, 2026
5 of 6 checks passed
@d-morrison d-morrison deleted the copilot/fill-in-aic-bic-details branch April 10, 2026 21:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands the course material on AIC/BIC model comparison (including formulas, conceptual interpretation, and attributions) and updates supporting bibliography/spellcheck artifacts.

Changes:

  • Adds detailed AIC/BIC exposition in the linear regression goodness-of-fit section (formulas, conceptual breakdown, comparison table, interpretation guidance, speaker notes with historical citations).
  • Adds Akaike (1974) and Schwarz (1978) entries to the bibliography.
  • Adds “Kullback” and “Leibler” to the package WORDLIST.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
_sec_linreg_gof.qmd Expands AIC/BIC section content, adds formulas/interpretation, and adds attribution + historical notes.
references.bib Adds bibliographic entries for Akaike (1974) and Schwarz (1978).
inst/WORDLIST Adds spelling whitelist entries for “Kullback” and “Leibler”.

Comment thread _sec_linreg_gof.qmd
Comment on lines +23 to +27
where $\ell(\hat\theta)$ is the log-likelihood evaluated at the
maximum-likelihood estimates $\hat\theta$,
$p$ is the number of estimated parameters
(including $\hat\sigma^2$ for Gaussian models),
and $n$ is the number of observations.
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In @def-aic, the prose defines n as the number of observations, but n doesn’t appear in the AIC formula. This is confusing and also forces @def-bic to reference @def-aic for n. Consider defining only \ell(\hat\theta) and p in @def-aic, and defining n in @def-bic (or explicitly note that n is used in BIC, not AIC).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fill in details for AIC/BIC section

3 participants