Fix database behavior#5
Open
palb91 wants to merge 3 commits intocym13:masterfrom
palb91:fix_db
Open
Conversation
Owner
|
Thank you for noticing, I've opened issue #6 to track that bug. Unfortunately I cannot accept the PR at the moment: while I agree that .config wasn't the wisest choice moving it to .local/share would be a breaking change that I'm not willing to accept at the moment. I'd be glad to have the bug fix part though. |
Author
|
Do you want 2 distinct PR? |
Author
|
Removed the xdg stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
--databaseflag just print the help and exit with code 1 but no specific error.This PR fix this issue and set a better default for the db (
~/.config/toolis not a good place for data).The standard is
~/.local/share/tool, checking theXDG_DATA_HOMEenv var first can help.