Skip to content

tests: add live migration during boot coverage#179

Merged
Coffeeri merged 2 commits intocyberus-technology:mainfrom
Coffeeri:fix/migration-virtio-activation-barrier
Mar 23, 2026
Merged

tests: add live migration during boot coverage#179
Coffeeri merged 2 commits intocyberus-technology:mainfrom
Coffeeri:fix/migration-virtio-activation-barrier

Conversation

@Coffeeri
Copy link
Copy Markdown
Contributor

@Coffeeri Coffeeri commented Mar 11, 2026

@Coffeeri Coffeeri self-assigned this Mar 11, 2026
Copy link
Copy Markdown
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced of the test case factory approach.

Moreover, ruff format the file.

Wait! Isn't this caught by CI?! 🫨

Comment thread tests/testsuite_migration.py Outdated
Comment thread tests/testsuite_migration.py Outdated
Comment thread tests/testsuite_migration.py Outdated
Comment thread tests/testsuite_migration.py Outdated
@Coffeeri Coffeeri force-pushed the fix/migration-virtio-activation-barrier branch 4 times, most recently from 7000c41 to a7bff64 Compare March 11, 2026 16:41
@Coffeeri Coffeeri requested a review from phip1611 March 12, 2026 07:45
@Coffeeri Coffeeri force-pushed the fix/migration-virtio-activation-barrier branch from a7bff64 to 8a17941 Compare March 12, 2026 08:05
@Coffeeri Coffeeri requested a review from tpressure March 12, 2026 08:09
@Coffeeri Coffeeri force-pushed the fix/migration-virtio-activation-barrier branch 2 times, most recently from 0421789 to 0f45fd9 Compare March 18, 2026 15:22
@phip1611

This comment was marked as outdated.

Comment thread tests/testsuite_migration.py Outdated
Comment thread tests/testsuite_migration.py Outdated
@Coffeeri Coffeeri force-pushed the fix/migration-virtio-activation-barrier branch from 0f45fd9 to 175fa5e Compare March 18, 2026 17:38
@Coffeeri Coffeeri requested a review from phip1611 March 19, 2026 07:11
Comment thread tests/testsuite_migration.py Outdated
Comment thread tests/testsuite_migration.py Outdated
@Coffeeri Coffeeri force-pushed the fix/migration-virtio-activation-barrier branch from 175fa5e to ef1b3e6 Compare March 19, 2026 12:20
@Coffeeri Coffeeri requested a review from tpressure March 19, 2026 12:21
Copy link
Copy Markdown
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing job!

Comment thread tests/testsuite_migration.py Outdated
Comment thread tests/testsuite_migration.py Outdated
Comment thread tests/testsuite_migration.py
Add a boot-time live migration test that starts the migration in a
detached screen session and verifies that the guest becomes reachable
on the destination host.

Run the scenario multiple times to catch flakiness.

On-behalf-of: SAP leander.kohler@sap.com
Signed-off-by: Leander Kohler <leander.kohler@cyberus-technology.de>
Replace the duplicated local migration_finished functions in the
migration tests with the shared helper added in the previous commit.

On-behalf-of: SAP leander.kohler@sap.com
Signed-off-by: Leander Kohler <leander.kohler@cyberus-technology.de>
@Coffeeri Coffeeri force-pushed the fix/migration-virtio-activation-barrier branch from ef1b3e6 to f38ad22 Compare March 23, 2026 14:04
@Coffeeri Coffeeri added this pull request to the merge queue Mar 23, 2026
Merged via the queue into cyberus-technology:main with commit 059637c Mar 23, 2026
3 checks passed
@Coffeeri Coffeeri deleted the fix/migration-virtio-activation-barrier branch March 23, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants