1.0.8/render block container as block for any non addresses#60
Open
mzagrabe wants to merge 2 commits intocvicente:masterfrom
Open
1.0.8/render block container as block for any non addresses#60mzagrabe wants to merge 2 commits intocvicente:masterfrom
mzagrabe wants to merge 2 commits intocvicente:masterfrom
Conversation
Don't just evaluate the first object of the array - this leads to issues where a container has static addresses at the top of the addressing block (first entry of the array) and the whole block is rendered as though they were hosts (addresses). Instead, default to 'address' and see if any of the objects are not addresses. If so, then set the type to 'block' and break the loop.
Regex anchors bind tighter than the alternation character (|). Thus we need to put our alternation expression in a (non-capturing) parenthesis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a container has a mix of addresses (hosts) and other subnets or containers it should display the block view if any of its descendants are non-addresses.