fix(ISSUE-24): JWT exp too far in future#25
Merged
Conversation
The iat was set 60s in the past for clock skew tolerance, but exp was calculated from current time, making the JWT lifetime 660s (11 minutes). GitHub requires JWTs to be valid for no more than 10 minutes. Fix: set iat to now (removing the -60s clock skew offset), keeping the lifetime at exactly 600s (10 minutes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iat was set 60s in the past for clock skew tolerance, but exp was calculated from current time, making the JWT lifetime 660s (11 minutes). GitHub requires JWTs to be valid for no more than 10 minutes.
Fix: set iat to now (removing the -60s clock skew offset), keeping the lifetime at exactly 600s (10 minutes).
Closes #24