fix(ISSUE-16): clear .npmrc auth token before provenance publish#20
Merged
Conversation
The OIDC trusted publisher flow was working for Sigstore provenance but the registry PUT was falling through to the empty _authToken in the temp .npmrc created by setup-node. The auth token line is now removed before publish, letting npm use OIDC for registry auth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm publish --provenancewas failing with404 Not Foundon the registry PUT. The OIDC flow worked for Sigstore provenance signing (succeeded), but the registry request fell through to the empty_authTokeninjected byactions/setup-node@v4into the temporary.npmrc.Fix
Before publishing, remove the
authTokenline from the temp.npmrcso npm uses OIDC (viaid-token: write) for registry authentication instead of the empty token. Also adds--access publicexplicitly.