Add domain-specific vulnerability entries across 8 domains#422
Open
omarinuwa wants to merge 5 commits into
Open
Add domain-specific vulnerability entries across 8 domains#422omarinuwa wants to merge 5 commits into
omarinuwa wants to merge 5 commits into
Conversation
Add 31 vulnerability entries across 4 EVM application domains: - DeFi Bridge (8): arbitrary calls, message auth, native tokens, recovery, return values, ERC-777, address assumptions, gas griefing - Merkle Tree (8): empty proof, leaf/node collision, replay, proof length, root validation, leaf context, inverted logic, root access control - Tick Math (7): slot0 misalignment, negative rounding, fee underflow, downcast, spacing, boundary crossing, TWAP inversion - Voting Governance (8): flash loans, double voting, quorum, timelock, snapshots, delegation, parameter changes, vote-after-transfer Each entry follows the existing not-so-smart-contracts template with Description, Exploit Scenario, Example (Solidity), and Mitigations sections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
Add 31 new not-so-smart-contract entries across 4 domains: - ERC-4337 (account abstraction): 8 entries covering EntryPoint hash omissions, cross-chain replay, paymaster drain, bundler gas manipulation, gas parameter validation, CREATE2 frontrunning, validation return values, and postOp exploitation - Slippage: 8 entries covering missing protection, on-chain calculation, hardcoded values, deadline expiration, unapplied parameters, shared tolerances, wrong-stage checks, and vault donation attacks - Precision Loss: 7 entries covering division ordering, rounding direction, ratio truncation, conflicting rounding, rounding DoS, decimal mismatches, and fee truncation bypass - Uniswap V4 Hooks: 8 entries covering permission flags, PoolManager bypass, reentrancy, state overwriting, spot price manipulation, delta sign conventions, JIT liquidity, and dynamic fee misconfiguration Rename evm-domains -> domain-specific-vulnerabilities for clarity. Update SUMMARY.md, root README, and section index. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…boilerplate - Rename all kebab-case directories to snake_case per style guide - Change ## Domains to ## Vulnerabilities in parent README - Add consistent SPDX/pragma boilerplate to ERC-4337 and Uniswap V4 entries Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Change parent README table header from "Domain" to "Name" - Add SPDX/pragma boilerplate to all 8 Merkle Tree code blocks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…bles Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 62 not-so-smart-contract entries across 8 domains under a new
domain-specific-vulnerabilities/section, covering vulnerability patterns tied to specific smart contract application areas.Also renames the section from
evm-domainstodomain-specific-vulnerabilitiesand updates SUMMARY.md, root README, and all navigation files.Test plan
🤖 Generated with Claude Code