Pin nightly to 2024-05-04 due to recently-enabled check-cfg#1109
Closed
ryoqun wants to merge 3 commits intocrossbeam-rs:masterfrom
Closed
Pin nightly to 2024-05-04 due to recently-enabled check-cfg#1109ryoqun wants to merge 3 commits intocrossbeam-rs:masterfrom
ryoqun wants to merge 3 commits intocrossbeam-rs:masterfrom
Conversation
Contributor
Author
|
@taiki-e could you review this? fyi, you can see ci builds as if these changes were on the master branch here: https://github.com/ryoqun/crossbeam/actions/runs/9089208830 (That's why I'm creating this pr from my fork's master branch). it seems that cirrus ci isn't run there understandably.. |
Member
|
Thanks for the PR! I would like to use rust-lang/cargo#13913 's config option instead if possible. |
Contributor
Author
@taiki-e seems rust-lang/cargo#13913 is synced to the rustc repo and nightly-2024-05-19 contains it. Although, the diagnostics aren't updated yet (rust-lang/rust#125219), I'll soon open another pr. so closing this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm jumping on this workaround in #1040 (comment) in desperation of shipping
select_biased!, assumingbuild.rsisn't a viable option (as concerns is raised upstream: rust-lang/rust#124800)....: