Fix misuse of Landmark in margin/size by introducing scalar type#236
Open
arnavsharma990 wants to merge 2 commits intocreativescala:mainfrom
Open
Fix misuse of Landmark in margin/size by introducing scalar type#236arnavsharma990 wants to merge 2 commits intocreativescala:mainfrom
arnavsharma990 wants to merge 2 commits intocreativescala:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect use of Landmark for margin and size semantics.
This change introduces a minimal layout-scoped scalar type (
Layout.Scalar) to represent relative values (e.g. fractions of bounding box dimensions), while preserving existing Double-based APIs.Layout.Scalar(absolute and fractional values)This approach is based on reviewer feedback in #222, where it was noted that a separate scalar magnitude type is required instead of using
Landmark.