Conversation
TimidRobot
left a comment
There was a problem hiding this comment.
Good to see this coming together! Acknowledging this is a WIP, you'll need to update labels and descriptions to provide context and make the data more meaningful.
It might also be worth looking to see if there's any way to automatically get the full names for units. I have no idea what the abbreviations mean.
cb5294c to
15720d1
Compare
TimidRobot
left a comment
There was a problem hiding this comment.
This is coming along nicely, keep up the good work!
|
@oree-xx please merge main again now that the CSV changes are there and ensure this PR has them as well |
| file_path = shared.path_join( | ||
| PATHS["data_phase"], "smithsonian_totals_by_units.csv" | ||
| ) | ||
| shared.data_to_csv(args, data, file_path) |
There was a problem hiding this comment.
With the merge from main, this function was renamed to shared.dataframe_to_csv.
As is, it generates an error:
ERROR - smithsonian_process - (1) Unhandled exception: Traceback (most recent call last):
File "/Users/timidrobot/git/creativecommons/quantifying/scripts/2-process/smithsonian_process.py", line 188, in <module>
main()
File "/Users/timidrobot/git/creativecommons/quantifying/scripts/2-process/smithsonian_process.py", line 173, in main
process_totals_by_units(args, count_data)
File "/Users/timidrobot/git/creativecommons/quantifying/scripts/2-process/smithsonian_process.py", line 96, in process_totals_by_units
shared.data_to_csv(args, data, file_path)
^^^^^^^^^^^^^^^^^^
AttributeError: module 'shared' has no attribute 'data_to_csv'
Traceback (most recent call last):
File "/Users/timidrobot/git/creativecommons/quantifying/scripts/2-process/smithsonian_process.py", line 188, in <module>
main()
File "/Users/timidrobot/git/creativecommons/quantifying/scripts/2-process/smithsonian_process.py", line 173, in main
process_totals_by_units(args, count_data)
File "/Users/timidrobot/git/creativecommons/quantifying/scripts/2-process/smithsonian_process.py", line 96, in process_totals_by_units
shared.data_to_csv(args, data, file_path)
^^^^^^^^^^^^^^^^^^
AttributeError: module 'shared' has no attribute 'data_to_csv'| file_path = shared.path_join( | ||
| PATHS["data_phase"], "smithsonian_totals_by_records.csv" | ||
| ) | ||
| shared.data_to_csv(args, data, file_path) |
There was a problem hiding this comment.
With the merge from main, this function was renamed to shared.dataframe_to_csv (see comment above).
Description
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin