-
Notifications
You must be signed in to change notification settings - Fork 1
Migrate to pnpm #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joncombe
wants to merge
1
commit into
master
Choose a base branch
from
jc/migrate-to-pnpm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate to pnpm #595
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,8 +20,7 @@ | |
| .env.production.local | ||
|
|
||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
|
|
||
| .idea/ | ||
| .eslintcache | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ignore-scripts=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v24.12.0 | ||
| 22.13.1 |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| # Migrating From Yarn to pnpm | ||
|
|
||
| This guide is for developers who already worked on the Yarn-based version of this repo. | ||
|
|
||
| ## What changed | ||
|
|
||
| - Package manager: Yarn -> pnpm | ||
| - Node version: standardized to `22.13.1` | ||
| - Lockfile: `yarn.lock` -> `pnpm-lock.yaml` | ||
|
|
||
| ## One-time local migration | ||
|
|
||
| From the repo root, run: | ||
|
|
||
| ```bash | ||
| nvm install 22.13.1 | ||
| nvm use 22.13.1 | ||
| corepack enable | ||
| corepack prepare pnpm@10.33.4 --activate | ||
| pnpm --version | ||
| rm -rf node_modules | ||
| pnpm install --frozen-lockfile | ||
| ``` | ||
|
|
||
| If `pnpm` is not available after setup, run: | ||
|
|
||
| ```bash | ||
| corepack prepare pnpm@10.33.4 --activate | ||
| ``` | ||
|
|
||
| ## Daily commands (Yarn -> pnpm) | ||
|
|
||
| - Install deps: `yarn install` -> `pnpm install` | ||
| - Start dev server: `yarn start` -> `pnpm start` | ||
| - Lint: `yarn lint` -> `pnpm lint` | ||
| - Build app: `yarn build` -> `pnpm build` | ||
| - Build library: `yarn build-lib` -> `pnpm build-lib` | ||
| - Test: `yarn test` -> `pnpm test` | ||
|
|
||
| ## Important notes for this repo | ||
|
|
||
| - Use Node `22.13.1` (see `.nvmrc`). | ||
| - Do not run `yarn` in this repository after migration. | ||
| - `pnpm-lock.yaml` is the source of truth for dependency resolution. | ||
| - If install-script behavior was previously controlled by Yarn config, check `.npmrc` in this repo for the current script policy. | ||
|
|
||
| ## Validation checklist after switching | ||
|
|
||
| Run the following and confirm all pass: | ||
|
|
||
| ```bash | ||
| pnpm install --frozen-lockfile | ||
| pnpm lint | ||
| pnpm build | ||
| pnpm build-lib | ||
| pnpm test | ||
| ``` | ||
|
|
||
| ## Troubleshooting | ||
|
|
||
| - Wrong Node version: | ||
| - `node -v` should report `v22.13.1`. | ||
| - Run `nvm use 22.13.1`. | ||
| - Lockfile mismatch errors: | ||
| - Make sure you are not using Yarn. | ||
| - Re-run `pnpm install --frozen-lockfile`. | ||
| - Strange module/link behavior after migration: | ||
| - Remove `node_modules` and reinstall with pnpm. | ||
| - Re-check local linking workflow, since pnpm linking behavior differs from Yarn in some cases. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative:
grep \"version\": package.json | cut -f2 -d: | cut -f2 -d\"