Skip to content

Add static fields and message containers#133

Merged
ashtum merged 2 commits intocppalliance:developfrom
ashtum:static-containers
Jun 4, 2025
Merged

Add static fields and message containers#133
ashtum merged 2 commits intocppalliance:developfrom
ashtum:static-containers

Conversation

@ashtum
Copy link
Copy Markdown
Collaborator

@ashtum ashtum commented May 28, 2025

No description provided.

@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

std::size_t storage_size) noexcept
: fields_view_base(&this->fields_base::h_)
, fields_base(
k, storage, storage_size)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to get rid of constructors should we require all constructors of fields_base to also have the string_view parameter, defaulted to the empty string?

Copy link
Copy Markdown
Collaborator Author

@ashtum ashtum Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll try that.
BTW, this issue will be resolved when we refactor the code to remove message_view_base from the hierarchy of response/request containers.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should do that though, as it results in duplication and I believe a loss of functionality


request_base(
char* storage,
std::size_t storage_size) noexcept
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be public

@ashtum ashtum force-pushed the static-containers branch from 26c4851 to b2c8107 Compare June 3, 2025 13:12
@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link
Copy Markdown

@ashtum ashtum force-pushed the static-containers branch from b2c8107 to 9b1242c Compare June 3, 2025 13:26
@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link
Copy Markdown

@ashtum ashtum force-pushed the static-containers branch from 9b1242c to 02f8553 Compare June 3, 2025 13:54
@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link
Copy Markdown

@ashtum ashtum force-pushed the static-containers branch from 02f8553 to f2d29bf Compare June 3, 2025 14:16
@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link
Copy Markdown

@ashtum ashtum force-pushed the static-containers branch from f2d29bf to 38b8776 Compare June 3, 2025 15:05
@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link
Copy Markdown

@ashtum ashtum force-pushed the static-containers branch from 38b8776 to b514329 Compare June 3, 2025 19:16
@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link
Copy Markdown

@ashtum ashtum force-pushed the static-containers branch from b514329 to c0db222 Compare June 4, 2025 05:42
@ashtum ashtum force-pushed the static-containers branch from c0db222 to a10bdb1 Compare June 4, 2025 05:46
@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

1 similar comment
@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link
Copy Markdown

@ashtum ashtum force-pushed the static-containers branch from a10bdb1 to b403f9a Compare June 4, 2025 09:29
@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://133.http-proto.prtest.cppalliance.org/index.html

@cppalliance-bot
Copy link
Copy Markdown

@ashtum ashtum marked this pull request as ready for review June 4, 2025 11:12
@ashtum ashtum merged commit 4d82d81 into cppalliance:develop Jun 4, 2025
59 of 60 checks passed
@ashtum ashtum deleted the static-containers branch October 4, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants