[lex.phases] Move dropping whitespace to end of phase 4#8117
Merged
Conversation
jensmaurer
requested changes
Jul 24, 2025
Phase 7 deals only with tokens, not whitespace. For clarity move the dropping of whitespace to the end of phase 4, after preprocessing directives are deleted. Newline characters are significant in the grammar of preprocessing directives to whitespace characters are clearly signicant until this point. Conversely, it is good to recognise that string literal preprocessing tokens are adjacted regardless of whitespace in phases 5 and 6.
AlisdairM
force-pushed
the
move_dropping_whitespace
branch
from
4099a09 to
8322e95
Compare
Contributor
|
Final thoughts, @jensmaurer? |
Member
|
This is not a technical concern, but more a social one. I've sent e-mail to the core reflector so people are aware of the move. Let's merge on Monday, unless there are objections. |
Contributor
Author
|
Is this ready to land? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 7 deals only with tokens, not whitespace. For clarity move the dropping of whitespace to the end of phase 4, after preprocessing directives are deleted. Newline characters are significant in the grammar of preprocessing directives to whitespace characters are clearly signicant until this point. Conversely, it is good to recognise that string literal preprocessing tokens are adjacted regardless of whitespace in phases 5 and 6.