Skip to content

[linalg.conj.conjugatedaccessor] Fix incorrect return type of nested_accessor#8105

Merged
tkoeppe merged 1 commit into
cplusplus:mainfrom
eisenwave:fix-nested-accessor
Jul 26, 2025
Merged

[linalg.conj.conjugatedaccessor] Fix incorrect return type of nested_accessor#8105
tkoeppe merged 1 commit into
cplusplus:mainfrom
eisenwave:fix-nested-accessor

Conversation

@eisenwave
Copy link
Copy Markdown
Member

@eisenwave eisenwave commented Jul 20, 2025

One part of #7214.

As @mhoemmen explains:

Fix return type of nested_accessor member function

The nested_accessor member function of conjugated_accessor (which is defined inline in the class' synopsis) currently returns const Accessor&. This is incorrect, because there is no Accessor type in scope.

The intent is for the function to return const NestedAccessor&. As main author of this proposal, this is the intent. At some point in revisions, the template parameter was renamed from Accessor to NestedAccessor. It's likely that we missed changing the return type of nested_accessor.

@jwakely does this need an LWG issue or can we "just fix this"?

@jensmaurer jensmaurer requested a review from jwakely July 26, 2025 14:24
Copy link
Copy Markdown
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems editorial

@tkoeppe tkoeppe merged commit b74580a into cplusplus:main Jul 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants