Clarify functions, member functions, and constructors#6946
Merged
tkoeppe merged 7 commits intoOct 30, 2025
Conversation
jwakely
reviewed
Apr 23, 2024
Contributor
|
Could you please reorganize this PR into one commit per affected Clause, and then format each commit message as per https://github.com/cplusplus/draft/wiki/Commit-message-format? |
frederick-vs-ja
force-pushed
the
functions-members-constructors
branch
from
abf59f7 to
c12c964
Compare
jwakely
approved these changes
Jun 18, 2025
Contributor
|
@jensmaurer for a core perspective? |
wg21bot
added
the
needs rebase
…lat.set.overview], [flat.multiset.overview] A constructor is a member function
frederick-vs-ja
force-pushed
the
functions-members-constructors
branch
from
c12c964 to
bfa24db
Compare
jensmaurer
removed
the
needs rebase
jensmaurer
approved these changes
Jul 25, 2025
Member
jensmaurer
left a comment
jensmaurer
left a comment
There was a problem hiding this comment.
I think that's a redundancy / clarity improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't say "constructors and/or member functions", "functions name or member function name". or "function or constructor" etc., because
I'm not very sure of the last point. But as a constexpr constructor is considered to be a constexpr function, I think it's consistent to say a constructor is a function.