Open
Conversation
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
cpburnz
reviewed
Mar 7, 2026
| """ | ||
|
|
||
| def __add__(self: Self, other: PathSpec) -> Self: | ||
| def __add__(self: Self, other: object) -> Self: |
Owner
There was a problem hiding this comment.
I think it's best to keep other: PathSpec.
If it's changed to other: object, then PyCharm will no longer flag:
spec2 = spec + 123 # Expected type 'PathSpec', got 'int' instead Does mypy complain about other not being hinted as object?
| return NotImplemented | ||
|
|
||
| def __iadd__(self: Self, other: PathSpec) -> Self: | ||
| def __iadd__(self: Self, other: object) -> Self: |
Owner
There was a problem hiding this comment.
I think it's best to keep other: PathSpec.
Unfortunately PyCharm does not flag this as an error even though type-wise it's wrong:
spec += 123Does mypy complain about other not being hinted as object?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a few quick updates from running mypy. The biggest one is
+currently assumes you can add theSequence's, which is not true for arbitrarySequence.