Migrate the playground config#4214
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the playground configuration from environment variables to TOML files, which improves configuration management. My review identifies issues with configuration file duplication and an inconsistency in volume mounts for the non-interactive playground setup. The suggested changes aim to consolidate the configuration and ensure consistency between services, which will improve maintainability and prevent potential configuration drift.
jmg-duarte
added
the
track:config-migration
MartinquaXD
left a comment
MartinquaXD
left a comment
There was a problem hiding this comment.
Looks alright to me. Didn't do a test trade to fully check the functionality, though.
I tested (the non-interactive one) and it worked, even if it doesn't work 100% it's less broken than the current status 😅 |
AryanGodara
left a comment
AryanGodara
left a comment
There was a problem hiding this comment.
This will be very helpful for the pod-network PR 🙌🏼 .
Takes long to build fresh on my machine, so late to the approval.
Did a manual trade to test on forked mainnet.
context: with non-interactive docker-compose file on MacOS
3 participants
Description
The playground was left behind amidst the config changes. This PR brings the playground back up to speed.
Changes
How to test
Run the playground and execute a trade