Skip to content

fix(integration): log fuzz seed so failures can be reproduced #7552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandy2008 wants to merge 1 commit into
base: master
Choose a base branch
from
+31 −15
Open

fix(integration): log fuzz seed so failures can be reproduced #7552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions integration/parquet_querier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ package integration
import (
"context"
"fmt"
"math/rand"
"path/filepath"
"slices"
"strconv"
Expand Down Expand Up @@ -89,7 +88,7 @@ func TestParquetFuzz(t *testing.T) {
require.NoError(t, writeFileToSharedDir(s, "alertmanager_configs", []byte{}))

ctx := context.Background()
rnd := rand.New(rand.NewSource(time.Now().Unix()))
rnd := newFuzzRand(t)
dir := filepath.Join(s.SharedDir(), "data")
numSeries := 10
numSamples := 60
Expand Down Expand Up @@ -240,7 +239,7 @@ func TestParquetProjectionPushdownFuzz(t *testing.T) {
require.NoError(t, writeFileToSharedDir(s, "alertmanager_configs", []byte{}))

ctx := context.Background()
rnd := rand.New(rand.NewSource(time.Now().Unix()))
rnd := newFuzzRand(t)
dir := filepath.Join(s.SharedDir(), "data")
numSeries := 20
numSamples := 100
Expand Down
41 changes: 29 additions & 12 deletions integration/query_fuzz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func TestNativeHistogramFuzz(t *testing.T) {
}

ctx := context.Background()
rnd := rand.New(rand.NewSource(time.Now().Unix()))
rnd := newFuzzRand(t)

dir := filepath.Join(s.SharedDir(), "data")
err = os.MkdirAll(dir, os.ModePerm)
Expand Down Expand Up @@ -222,7 +222,7 @@ func TestExperimentalPromQLFuncsWithPrometheus(t *testing.T) {
}

ctx := context.Background()
rnd := rand.New(rand.NewSource(time.Now().Unix()))
rnd := newFuzzRand(t)

dir := filepath.Join(s.SharedDir(), "data")
err = os.MkdirAll(dir, os.ModePerm)
Expand Down Expand Up @@ -357,7 +357,7 @@ func TestDisableChunkTrimmingFuzz(t *testing.T) {

waitUntilReady(t, context.Background(), c1, c2, `{job="test"}`, start, now)

rnd := rand.New(rand.NewSource(now.Unix()))
rnd := newFuzzRand(t)
opts := []promqlsmith.Option{
// @ modifier and offset disabled: known bug in Prometheus (e.g. predict_linear with @/offset can panic).
promqlsmith.WithEnabledFunctions(enabledFunctions),
Expand Down Expand Up @@ -538,7 +538,7 @@ func TestExpandedPostingsCacheFuzz(t *testing.T) {
}
}

rnd := rand.New(rand.NewSource(now.Unix()))
rnd := newFuzzRand(t)
opts := []promqlsmith.Option{
// @ modifier and offset disabled: known bug in Prometheus (e.g. predict_linear with @/offset can panic).
promqlsmith.WithEnabledAggrs(enabledAggrs),
Expand Down Expand Up @@ -767,7 +767,7 @@ func TestVerticalShardingFuzz(t *testing.T) {

waitUntilReady(t, context.Background(), c1, c2, `{job="test"}`, start, end)

rnd := rand.New(rand.NewSource(now.Unix()))
rnd := newFuzzRand(t)
opts := []promqlsmith.Option{
// @ modifier and offset disabled: known bug in Prometheus (e.g. predict_linear with @/offset can panic).
promqlsmith.WithEnabledFunctions(enabledFunctions),
Expand Down Expand Up @@ -883,7 +883,7 @@ func TestProtobufCodecFuzz(t *testing.T) {

waitUntilReady(t, context.Background(), c1, c2, `{job="test"}`, start, end)

rnd := rand.New(rand.NewSource(now.Unix()))
rnd := newFuzzRand(t)
opts := []promqlsmith.Option{
// @ modifier and offset disabled: known bug in Prometheus (e.g. predict_linear with @/offset can panic).
promqlsmith.WithEnabledFunctions(enabledFunctions),
Expand Down Expand Up @@ -1202,7 +1202,7 @@ func TestStoreGatewayLazyExpandedPostingsSeriesFuzz(t *testing.T) {
lbls = append(lbls, labels.FromStrings(labels.MetricName, metricName, "job", "test", "series", strconv.Itoa(i%200), "status_code", statusCodes[i%5]))
}
ctx := context.Background()
rnd := rand.New(rand.NewSource(time.Now().Unix()))
rnd := newFuzzRand(t)

dir := t.TempDir()
storage, err := e2ecortex.NewS3ClientForMinio(minio, flags["-blocks-storage.s3.bucket-name"])
Expand Down Expand Up @@ -1357,7 +1357,7 @@ func TestStoreGatewayLazyExpandedPostingsSeriesFuzzWithPrometheus(t *testing.T)
lbls = append(lbls, labels.FromStrings(labels.MetricName, metricName, "job", "test", "series", strconv.Itoa(i%200), "status_code", statusCodes[i%5]))
}
ctx := context.Background()
rnd := rand.New(rand.NewSource(time.Now().Unix()))
rnd := newFuzzRand(t)

dir := filepath.Join(s.SharedDir(), "data")
err = os.MkdirAll(dir, os.ModePerm)
Expand Down Expand Up @@ -1590,7 +1590,7 @@ func TestBackwardCompatibilityQueryFuzz(t *testing.T) {
ctx := context.Background()
waitUntilReady(t, ctx, c1, c2, `{job="test"}`, start, end)

rnd := rand.New(rand.NewSource(now.Unix()))
rnd := newFuzzRand(t)
opts := []promqlsmith.Option{
// @ modifier and offset disabled: known bug in Prometheus (e.g. predict_linear with @/offset can panic).
promqlsmith.WithEnabledFunctions(enabledFunctions),
Expand Down Expand Up @@ -1662,7 +1662,7 @@ func TestPrometheusCompatibilityQueryFuzz(t *testing.T) {
}

ctx := context.Background()
rnd := rand.New(rand.NewSource(time.Now().Unix()))
rnd := newFuzzRand(t)

dir := filepath.Join(s.SharedDir(), "data")
err = os.MkdirAll(dir, os.ModePerm)
Expand Down Expand Up @@ -1816,8 +1816,7 @@ func TestRW1vsRW2QueryFuzz(t *testing.T) {
_, err = c2.PushV2(symbols, v2Series)
require.NoError(t, err)

seed := now.Unix()
rnd := rand.New(rand.NewSource(seed))
rnd := newFuzzRand(t)

ctx := context.Background()
waitUntilReady(t, ctx, c1, c2, `{job="test"}`, start, end)
Expand Down Expand Up @@ -1980,6 +1979,24 @@ func shouldUseSampleNumComparer(query string) bool {
return false
}

// newFuzzRand returns a *rand.Rand whose seed is logged via t.Logf so failing
// fuzz cases can be reproduced. By default the seed is time.Now().Unix();
// setting FUZZ_SEED to a base-10 int64 overrides the default and pins the
// run to a specific seed.
func newFuzzRand(t *testing.T) *rand.Rand {
seed := time.Now().Unix()
if v := os.Getenv("FUZZ_SEED"); v != "" {
if parsed, err := strconv.ParseInt(v, 10, 64); err == nil {
t.Logf("integration fuzz random seed: overridden to %d via FUZZ_SEED", parsed)
seed = parsed
} else {
t.Logf("integration fuzz random seed: ignoring invalid FUZZ_SEED=%q: %v", v, err)
}
}
t.Logf("integration fuzz random seed: %d (override with FUZZ_SEED env var)", seed)
return rand.New(rand.NewSource(seed))
}

func isValidQuery(generatedQuery parser.Expr, skipBackwardIncompat bool) bool {
isValid := true
queryStr := generatedQuery.String()
Expand Down
Loading