Add local cache to regexResolver#7363
Merged
SungJin1212 merged 6 commits intoMar 23, 2026
Merged
Conversation
SungJin1212
force-pushed
the
Add-local-cache-to-regexResolver
branch
4 times, most recently
from
7602f56 to
19d55ef
Compare
friedrichg
approved these changes
Mar 20, 2026
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
Minor nit only on documenting the experimental feature. merge at will
| # CLI flag: -tenant-federation.user-sync-interval | ||
| [user_sync_interval: <duration> | default = 5m] | ||
|
|
||
| # [Experimental] Cache size of regex match results used by regex resolver. |
Member
There was a problem hiding this comment.
If it is experimental it should be mentioned in v1-guarantees
|
|
||
| "github.com/go-kit/log" | ||
| "github.com/go-kit/log/level" | ||
| lru "github.com/hashicorp/golang-lru/v2" |
Member
There was a problem hiding this comment.
lru is the right choice. I feel.
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Add-local-cache-to-regexResolver
branch
from
6d36905 to
363d6a5
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
friedrichg
pushed a commit
that referenced
this pull request
Apr 17, 2026
* Add local cache to regexResolver Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * Add cache hit/miss metrics Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * Refactor test Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * fix lint Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * update v1-guarantees Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * annotation Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> --------- Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
friedrichg
pushed a commit
that referenced
this pull request
Apr 17, 2026
* Add local cache to regexResolver Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * Add cache hit/miss metrics Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * Refactor test Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * fix lint Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * update v1-guarantees Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * annotation Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> --------- Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
friedrichg
pushed a commit
that referenced
this pull request
Apr 17, 2026
* Add local cache to regexResolver Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * Add cache hit/miss metrics Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * Refactor test Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * fix lint Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * update v1-guarantees Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * annotation Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> --------- Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
friedrichg
added a commit
that referenced
this pull request
Apr 17, 2026
* Add local cache to regexResolver (#7363) * Add local cache to regexResolver Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * Add cache hit/miss metrics Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * Refactor test Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * fix lint Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * update v1-guarantees Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * annotation Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> --------- Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> * Re-order changelog Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> --------- Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> Co-authored-by: SungJin1212 <tjdwls1201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a local cache (map) to store already resolved and validated tenant lists.
Benchmark Result
This is result of the
BenchmarkRegexResolver_TenantIDs.Which issue(s) this PR fixes:
Fixes #7360
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]