Add unit tests for histogram proto conversions#7354
Merged
friedrichg merged 3 commits intoMar 20, 2026
Merged
Conversation
Signed-off-by: Artem Muterko <artem@sopho.tech>
friedrichg
reviewed
Mar 16, 2026
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
Thanks!
it would be nice to test HistogramProtoToFloatHistogram too
Co-authored-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> Signed-off-by: Archy <6429715+archy-rock3t-cloud@users.noreply.github.com>
Co-authored-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> Signed-off-by: Archy <6429715+archy-rock3t-cloud@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds unit tests for the histogram protobuf conversion functions in
pkg/cortexpb/histograms.go. Tests cover round-trip conversions for both integer and float histograms, panic behavior when calling conversion functions with the wrong histogram type,HistogramPromProtoToHistogramProtofor both int and float variants, and span conversion helpers including nil input handling.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]