Skip to content

Graduate instance limits from experimental #7316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
friedrichg merged 1 commit into from
Mar 3, 2026
Merged

Graduate instance limits from experimental #7316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/configuration/v1-guarantees.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ Currently experimental features are:
- `-tenant-federation.user-sync-interval`
- The thanosconvert tool for converting Thanos block metadata to Cortex
- HA Tracker: cleanup of old replicas from KV Store.
- Instance limits in ingester and distributor
- Exemplar storage, currently in-memory only within the Ingester based on Prometheus exemplar storage (`-blocks-storage.tsdb.max-exemplars`)
- Querier limits:
- `-querier.max-fetched-chunks-per-query`
Expand Down
4 changes: 0 additions & 4 deletions pkg/distributor/distributor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,10 +480,6 @@ func New(cfg Config, clientConfig ingester_client.Config, limits *validation.Ove
}

func (d *Distributor) starting(ctx context.Context) error {
if d.cfg.InstanceLimits != (InstanceLimits{}) {
util_log.WarnExperimentalUse("distributor instance limits")
}

// Only report success if all sub-services start properly
return services.StartManagerAndAwaitHealthy(ctx, d.subservices)
}
Expand Down
5 changes: 0 additions & 5 deletions pkg/ingester/ingester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,11 +1029,6 @@ func (i *Ingester) stopping(_ error) error {
}

func (i *Ingester) updateLoop(ctx context.Context) error {
if limits := i.getInstanceLimits(); limits != nil && *limits != (InstanceLimits{}) {
// This check will not cover enabling instance limits in runtime, but it will do for now.
logutil.WarnExperimentalUse("ingester instance limits")
}

rateUpdateTicker := time.NewTicker(i.cfg.RateUpdatePeriod)
defer rateUpdateTicker.Stop()

Expand Down
Loading